Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm to 6.6.0 #25551

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 6.6.0 #25551

wants to merge 1 commit into from

Conversation

aeschright
Copy link

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Where this should land
  • Node 10
  • Node 8
Notable Changes

This is a pre-release of npm@6.6.0. This release marks the end of a massive internal refactor to npm that means we finally got rid of the legacy npm-registry-client in favor of the shiny, new, window.fetch-like npm-registry-fetch. Check the PR if you'd like to see the details.

Changelog

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Jan 17, 2019
@MylesBorins
Copy link
Contributor

I think something may have gone wrong in the upgrade... it only appears to have changes to documentation. deps/npm/package.json seems to still say 6.5.0

@aeschright
Copy link
Author

Sorry about that! Looks like it was a typo on my part. I pushed the correct version to the PR branch.

@aeschright
Copy link
Author

Just to make sure we have a consistent process: our docs say we should be sending you the release candidate once it's final but before our own release. Is that correct? For example, I'd be sending 6.6.0-next.1 which became 6.6.0.

@MylesBorins
Copy link
Contributor

MylesBorins commented Jan 18, 2019 via email

@bricss
Copy link

bricss commented Jan 21, 2019

npm 6.7.0 released.

@aduh95
Copy link
Contributor

aduh95 commented Jan 27, 2019

@aeschright should this PR be updated to have npm 6.7.0 instead of 6.6.0?

@zkat zkat mentioned this pull request Jan 29, 2019
4 tasks
@richardlau
Copy link
Member

Thanks @aeschright. Superseded by #25804.

@richardlau richardlau closed this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants